Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a few underpopulated testdata files #2405

Open
sdasgup3 opened this issue Jun 20, 2024 · 1 comment
Open

Fix a few underpopulated testdata files #2405

sdasgup3 opened this issue Jun 20, 2024 · 1 comment

Comments

@sdasgup3
Copy link
Member

The following tests does not test any stablehlo ops other than stablehlo.constant. From the name It seems they are intended to test some other ops but skipped somehow. Let explore fixing (delete or populate as intended) them.

https://github.com/openxla/stablehlo/blob/main/stablehlo/testdata/integer_pow_dtypes_shape_complex64_20_30__y_1.mlir
https://github.com/openxla/stablehlo/blob/main/stablehlo/testdata/device_put_dtypes_shape_int32_3_4__device_None.mlir
https://github.com/openxla/stablehlo/blob/main/stablehlo/testdata/convert_element_type_dtypes_to_dtypes_shape_uint8_100_100__olddtype_uint8_newdtype_uint8.mlir
https://github.com/openxla/stablehlo/blob/main/stablehlo/testdata/broadcast_in_dim_dtypes_shape_complex64_2__outshape__2___broadcastdimensions__0.mlir
https://github.com/openxla/stablehlo/blob/main/stablehlo/testdata/broadcast_in_dim_dtypes_shape_uint32_2__outshape__2___broadcastdimensions__0.mlir
https://github.com/openxla/stablehlo/blob/main/stablehlo/testdata/stop_gradient_float32_20_20.mlir
https://github.com/openxla/stablehlo/blob/main/stablehlo/testdata/convert_element_type_dtypes_to_dtypes_shape_float32_100_100__olddtype_float32_newdtype_float32.mlir
https://github.com/openxla/stablehlo/blob/main/stablehlo/testdata/stop_gradient_int8_20_20.mlir
https://github.com/openxla/stablehlo/blob/main/stablehlo/testdata/convert_element_type_dtypes_to_dtypes_shape_int32_100_100__olddtype_int32_newdtype_int32.mlir
https://github.com/openxla/stablehlo/blob/main/stablehlo/testdata/broadcast_in_dim_dtypes_shape_bfloat16_2__outshape__2___broadcastdimensions__0.mlir
https://github.com/openxla/stablehlo/blob/main/stablehlo/testdata/device_put_dtypes_shape_uint32_3_4__device_None.mlir
https://github.com/openxla/stablehlo/blob/main/stablehlo/testdata/convert_element_type_dtypes_to_dtypes_shape_int8_100_100__olddtype_int8_newdtype_int8.mlir
https://github.com/openxla/stablehlo/blob/main/stablehlo/testdata/device_put_dtypes_shape_bfloat16_3_4__device_None.mlir
https://github.com/openxla/stablehlo/blob/main/stablehlo/testdata/convert_element_type_dtypes_to_dtypes_shape_bool_100_100__olddtype_bool_newdtype_bool.mlir
https://github.com/openxla/stablehlo/blob/main/stablehlo/testdata/integer_pow_dtypes_shape_bfloat16_20_30__y_1.mlir
https://github.com/openxla/stablehlo/blob/main/stablehlo/testdata/device_put_devices_shape_float32_3_4__device__cpu.mlir
https://github.com/openxla/stablehlo/blob/main/stablehlo/testdata/integer_pow_dtypes_shape_int8_20_30__y_1.mlir
https://github.com/openxla/stablehlo/blob/main/stablehlo/testdata/stop_gradient_uint32_20_20.mlir
https://github.com/openxla/stablehlo/blob/main/stablehlo/testdata/convert_element_type_dtypes_to_dtypes_shape_bfloat16_100_100__olddtype_bfloat16_newdtype_bfloat16.mlir
https://github.com/openxla/stablehlo/blob/main/stablehlo/testdata/broadcast_in_dim_dtypes_shape_int8_2__outshape__2___broadcastdimensions__0.mlir
https://github.com/openxla/stablehlo/blob/main/stablehlo/testdata/integer_pow_dtypes_shape_int32_20_30__y_1.mlir
https://github.com/openxla/stablehlo/blob/main/stablehlo/testdata/stop_gradient_uint16_20_20.mlir
https://github.com/openxla/stablehlo/blob/main/stablehlo/testdata/device_put_dtypes_shape_int8_3_4__device_None.mlir
https://github.com/openxla/stablehlo/blob/main/stablehlo/testdata/stop_gradient_float16_20_20.mlir
https://github.com/openxla/stablehlo/blob/main/stablehlo/testdata/convert_element_type_dtypes_to_dtypes_shape_int16_100_100__olddtype_int16_newdtype_int16.mlir
https://github.com/openxla/stablehlo/blob/main/stablehlo/testdata/stop_gradient_int32_20_20.mlir
https://github.com/openxla/stablehlo/blob/main/stablehlo/testdata/device_put_dtypes_shape_uint16_3_4__device_None.mlir
https://github.com/openxla/stablehlo/blob/main/stablehlo/testdata/device_put_dtypes_shape_int16_3_4__device_None.mlir
https://github.com/openxla/stablehlo/blob/main/stablehlo/testdata/broadcast_in_dim_dtypes_shape_uint8_2__outshape__2___broadcastdimensions__0.mlir
https://github.com/openxla/stablehlo/blob/main/stablehlo/testdata/device_put_dtypes_shape_complex64_3_4__device_None.mlir
https://github.com/openxla/stablehlo/blob/main/stablehlo/testdata/convert_element_type_dtypes_to_dtypes_shape_uint16_100_100__olddtype_uint16_newdtype_uint16.mlir
https://github.com/openxla/stablehlo/blob/main/stablehlo/testdata/integer_pow_dtypes_shape_uint16_20_30__y_1.mlir
https://github.com/openxla/stablehlo/blob/main/stablehlo/testdata/convert_element_type_dtypes_to_dtypes_shape_float16_100_100__olddtype_float16_newdtype_float16.mlir
https://github.com/openxla/stablehlo/blob/main/stablehlo/testdata/stop_gradient_int16_20_20.mlir
https://github.com/openxla/stablehlo/blob/main/stablehlo/testdata/integer_pow_dtypes_shape_uint8_20_30__y_1.mlir
https://github.com/openxla/stablehlo/blob/main/stablehlo/testdata/broadcast_in_dim_dtypes_shape_bool_2__outshape__2___broadcastdimensions__0.mlir
https://github.com/openxla/stablehlo/blob/main/stablehlo/testdata/convert_element_type_dtypes_to_dtypes_shape_uint32_100_100__olddtype_uint32_newdtype_uint32.mlir
https://github.com/openxla/stablehlo/blob/main/stablehlo/testdata/integer_pow_dtypes_shape_float16_20_30__y_1.mlir
https://github.com/openxla/stablehlo/blob/main/stablehlo/testdata/stop_gradient_bfloat16_20_20.mlir
https://github.com/openxla/stablehlo/blob/main/stablehlo/testdata/broadcast_in_dim_dtypes_shape_int16_2__outshape__2___broadcastdimensions__0.mlir
https://github.com/openxla/stablehlo/blob/main/stablehlo/testdata/integer_pow_dtypes_shape_uint32_20_30__y_1.mlir
https://github.com/openxla/stablehlo/blob/main/stablehlo/testdata/integer_pow_dtypes_shape_int16_20_30__y_1.mlir
https://github.com/openxla/stablehlo/blob/main/stablehlo/testdata/broadcast_in_dim_dtypes_shape_uint16_2__outshape__2___broadcastdimensions__0.mlir
https://github.com/openxla/stablehlo/blob/main/stablehlo/testdata/device_put_dtypes_shape_float16_3_4__device_None.mlir
https://github.com/openxla/stablehlo/blob/main/stablehlo/testdata/convert_element_type_dtypes_to_dtypes_shape_complex64_100_100__olddtype_complex64_newdtype_complex64.mlir
https://github.com/openxla/stablehlo/blob/main/stablehlo/testdata/stop_gradient_uint8_20_20.mlir
https://github.com/openxla/stablehlo/blob/main/stablehlo/testdata/device_put_dtypes_shape_bool_3_4__device_None.mlir
https://github.com/openxla/stablehlo/blob/main/stablehlo/testdata/device_put_dtypes_shape_float32_3_4__device_None.mlir
https://github.com/openxla/stablehlo/blob/main/stablehlo/testdata/integer_pow_dtypes_shape_float32_20_30__y_1.mlir
https://github.com/openxla/stablehlo/blob/main/stablehlo/testdata/stop_gradient_bool_20_20.mlir
https://github.com/openxla/stablehlo/blob/main/stablehlo/testdata/device_put_dtypes_shape_uint8_3_4__device_None.mlir
https://github.com/openxla/stablehlo/blob/main/stablehlo/testdata/broadcast_in_dim_dtypes_shape_float16_2__outshape__2___broadcastdimensions__0.mlir
https://github.com/openxla/stablehlo/blob/main/stablehlo/testdata/broadcast_in_dim_dtypes_shape_int32_2__outshape__2___broadcastdimensions__0.mlir
https://github.com/openxla/stablehlo/blob/main/stablehlo/testdata/stop_gradient_complex64_20_20.mlir
https://github.com/openxla/stablehlo/blob/main/stablehlo/testdata/broadcast_in_dim_dtypes_shape_float32_2__outshape__2___broadcastdimensions__0.mlir
@sdasgup3
Copy link
Member Author

As pointed by @ghpvnist,
There are tests (e.g.
https://github.com/openxla/stablehlo/blob/main/stablehlo/testdata/integer_pow_dtypes_shape_complex64_20_30__y_0.mlir) with test-name suggesting something else that what the test is doing(e.g. the test does broadcast but the test name suggests it should be doing integer pow).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant