Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

:octocat: Don't scan .git folder by default ⚡ #201

Open
benedikt-bartscher opened this issue Feb 17, 2023 · 2 comments
Open

:octocat: Don't scan .git folder by default ⚡ #201

benedikt-bartscher opened this issue Feb 17, 2023 · 2 comments
Assignees
@tamere-allo-peter
Labels
BUILD enhancement New feature or request good first issue Good for newcomers quickfix

Comments

@benedikt-bartscher
Copy link

just a minimalist issue to improve performance.
currently yamlfixer scans the whole .git folder for yaml files by default. it can be observed by using yamlfixers -d flag
@adriens adriens added enhancement New feature or request good first issue Good for newcomers BUILD quickfix labels Feb 17, 2023
@adriens adriens changed the title dont scan .git folder by default :octocat: Don't scan .git folder by default ⚡ Feb 17, 2023
@adriens
Copy link
Member

adriens commented Feb 17, 2023

@tamere-allo-peter looks like we have a Quicfkix here 💭

@adriens adriens pinned this issue Feb 17, 2023
@tamere-allo-peter
Copy link
Member

Looks like à duplicate of #189 : yamlfixer should simply ignore the very same files that are ignored by yamllint, which it currently does not, but should ignore files on its own : ignoring .git would be introducing a special case for no reason.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tamere-allo-peter tamere-allo-peter

Labels
BUILD enhancement New feature or request good first issue Good for newcomers quickfix
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@adriens @benedikt-bartscher @tamere-allo-peter