Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LPtest() fails on some systems while installation is correct #66

Open
FELman2011 opened this issue Oct 6, 2021 · 1 comment
Open

LPtest() fails on some systems while installation is correct #66

FELman2011 opened this issue Oct 6, 2021 · 1 comment

Comments

@FELman2011
Copy link

After installing LightPipes and running LPtest(), the test sometimes fails while the installation is correct. In the test an optical field is initialized, propagated over a distance using the Fresnel propagator and the resulting intensity is summed and compared with a predefined value. The comparison is of the form a==b, which means that the two need to be equal up to and including the last digit. Depending on python version, machine precision, etc., the two values may actually differ slightly (e.g in the last or last two digits). A better test would be to check that abs(a-b) is less than a threshold value to determine if the installation is correct.

Furthermore, the text printed after test is successful differs from the text mentioned in the manual (at least in version 2.0.9)

@FredvanGoor
Copy link
Member

Yes you are right! I have changed that in the newest version (2.1.1)
Thank you,
Fred.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants