You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
OpenJDK 64-Bit Server VM (17.0.10+7-LTS) for windows-amd64 JRE (17.0.10+7-LTS), built on Jan 10 2024 22:11:07 by "Administrator" with
MS VC++ 16.10 / 16.11 (VS2019)
Have you verified this issue still happens when using the latest snapshot?
No, but the source code still looks the same.
Describe the issue
Access to host classes static fields is not inherited from interfaces or base classes.
In the given example, in Java and Rhino, "Implementation.INTERFACE_CONSTANT" would yield "X", in Graal, it yields "undefined".
Code snippet or code repository that reproduces the issue
/**
* The Interface Interface.
*/
public interface Interface {
/** The constant. */
public static final String INTERFACE_CONSTANT = "X";
}
/**
* The Class BaseImplementation.
*/
public static class BaseImplementation {
/** The Constant BASE_CONSTANT. */
public static final String BASE_CONSTANT = "Y";
}
/**
* The Class Implementation.
*/
public static class Implementation extends BaseImplementation implements Interface {
}
/**
* Test.
*/
@Test
public void test() {
try (Context context = Context.newBuilder("js")
.allowHostAccess(org.graalvm.polyglot.HostAccess.ALL)
.allowHostClassLookup(className -> true) // Allow access to all classes
.build()) {
Value result;
// yields null, yet in Java, "Implementation.INTERFACE_CONSTANT" yields "X"
result = context.eval("js", "(Java.type('" + Implementation.class.getName() + "')).INTERFACE_CONSTANT");
// assertEquals(Implementation.INTERFACE_CONSTANT, result.asString());
assertNull(result.asString());
// yields null, yet in Java, "Implementation.BASE_CONSTANT" yields "Y"
result = context.eval("js", "(Java.type('" + Implementation.class.getName() + "')).BASE_CONSTANT");
// assertEquals(Implementation.BASE_CONSTANT, result.asString());
assertNull(result.asString());
// yields "X", since we are accessing the interface directly
result = context.eval("js", "(Java.type('" + Interface.class.getName() + "')).INTERFACE_CONSTANT");
assertEquals("X", result.asString());
// yields "Y", since we are accessing the base class directly
result = context.eval("js", "(Java.type('" + BaseImplementation.class.getName() + "')).BASE_CONSTANT");
assertEquals("Y", result.asString());
}
}
While collectPublicMethods makes use of allowsAccessInheritance and inherits methods,
the method collectPublicFields does not. See
// do not inherit static fields
if (f.getDeclaringClass() == type && hostAccess.allowsAccess(f)) {
staticFieldMap.put(f.getName(), HostFieldDesc.unreflect(lookup, f));
}
Expected behavior
Along the lines of Java and Rhino, one would expect that public static fields are also inherited from Interfaces and Superclasses.
If behaviour would be broken by simply changing the code, mabye introducing allowsAccessFieldInheritance would help to introduce this functionality while staying backwards compatible.
The text was updated successfully, but these errors were encountered:
Describe GraalVM and your environment :
java -Xinternalversion
:Have you verified this issue still happens when using the latest snapshot?
No, but the source code still looks the same.
Describe the issue
Access to host classes static fields is not inherited from interfaces or base classes.
In the given example, in Java and Rhino, "Implementation.INTERFACE_CONSTANT" would yield "X", in Graal, it yields "undefined".
Code snippet or code repository that reproduces the issue
Steps to reproduce the issue
See example.
The code to "blame" seems to be here:
https://github.com/oracle/graal/blob/master/truffle/src/com.oracle.truffle.host/src/com/oracle/truffle/host/HostClassDesc.java#L354
While
collectPublicMethods
makes use ofallowsAccessInheritance
and inherits methods,the method
collectPublicFields
does not. SeeExpected behavior
Along the lines of Java and Rhino, one would expect that public static fields are also inherited from Interfaces and Superclasses.
If behaviour would be broken by simply changing the code, mabye introducing
allowsAccessFieldInheritance
would help to introduce this functionality while staying backwards compatible.The text was updated successfully, but these errors were encountered: