Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maybe need to add more detailed metadata for io.netty:netty-* #89

Closed
linghengqian opened this issue Oct 23, 2022 · 3 comments
Closed

Maybe need to add more detailed metadata for io.netty:netty-* #89

linghengqian opened this issue Oct 23, 2022 · 3 comments
Labels
enhancement New feature or request

Comments

@linghengqian
Copy link
Contributor

linghengqian commented Oct 23, 2022

Is your feature request related to a problem? Please describe.
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]

Describe the solution you'd like
A clear and concise description of what you want to happen.

Warning: Properties file at 'jar:file:///home/runner/.m2/repository/io/netty/netty-codec-http2/4.1.84.Final/netty-codec-http2-4.1.84.Final.jar!/META-INF/native-image/io.netty/codec-http2/native-image.properties' does not match the recommended 'META-INF/native-image/io.netty/netty-codec-http2/native-image.properties' layout.
Warning:  Properties file at 'jar:file:///home/runner/.m2/repository/io/netty/netty-resolver-dns/4.1.84.Final/netty-resolver-dns-4.1.84.Final.jar!/META-INF/native-image/io.netty/resolver-dns/native-image.properties' does not match the recommended 'META-INF/native-image/io.netty/netty-resolver-dns/native-image.properties' layout.
Warning:  Properties file at 'jar:file:///home/runner/.m2/repository/io/netty/netty-transport/4.1.84.Final/netty-transport-4.1.84.Final.jar!/META-INF/native-image/io.netty/transport/native-image.properties' does not match the recommended 'META-INF/native-image/io.netty/netty-transport/native-image.properties' layout.
Warning: Properties file at 'jar:file:///home/runner/.m2/repository/io/netty/netty-common/4.1.84.Final/netty-common-4.1.84.Final.jar!/META-INF/native-image/io.netty/common/native-image.properties' does not match the recommended 'META-INF/native-image/io.netty/netty-common/native-image.properties' layout.
Warning:  Properties file at 'jar:file:///home/runner/.m2/repository/io/netty/netty-codec/4.1.84.Final/netty-codec-4.1.84.Final.jar!/META-INF/native-image/codec-handlers/native-image.properties' does not match the recommended 'META-INF/native-image/io.netty/netty-codec/native-image.properties' layout.
Warning:  Properties file at 'jar:file:///home/runner/.m2/repository/io/netty/netty-handler/4.1.84.Final/netty-handler-4.1.84.Final.jar!/META-INF/native-image/io.netty/handler/native-image.properties' does not match the recommended 'META-INF/native-image/io.netty/netty-handler/native-image.properties' layout.
Warning:  Properties file at 'jar:file:///home/runner/.m2/repository/io/netty/netty-codec-http/4.1.84.Final/netty-codec-http-4.1.84.Final.jar!/META-INF/native-image/io.netty/codec-http/native-image.properties' does not match the recommended 'META-INF/native-image/io.netty/netty-codec-http/native-image.properties' layout.
Warning:  Properties file at 'jar:file:///home/runner/.m2/repository/io/netty/netty-buffer/4.1.84.Final/netty-buffer-4.1.84.Final.jar!/META-INF/native-image/io.netty/buffer/native-image.properties' does not match the recommended 'META-INF/native-image/io.netty/netty-buffer/native-image.properties' layout.
Warning: Could not register io.netty.handler.codec.compression.Lz4FrameDecoder: queryAllPublicMethods for reflection. Reason: java.lang.NoClassDefFoundError: net/jpountz/lz4/LZ4Exception.
Warning: Could not register io.netty.handler.codec.compression.Lz4FrameEncoder: queryAllPublicMethods for reflection. Reason: java.lang.NoClassDefFoundError: net/jpountz/lz4/LZ4Exception.
Warning: Could not register io.netty.handler.codec.marshalling.CompatibleMarshallingDecoder: queryAllPublicMethods for reflection. Reason: java.lang.NoClassDefFoundError: org/jboss/marshalling/ByteInput.
Warning: Could not register io.netty.handler.codec.marshalling.CompatibleMarshallingEncoder: queryAllPublicMethods for reflection. Reason: java.lang.NoClassDefFoundError: org/jboss/marshalling/ByteOutput.
Warning: Could not register io.netty.handler.codec.marshalling.MarshallingDecoder: queryAllPublicMethods for reflection. Reason: java.lang.NoClassDefFoundError: org/jboss/marshalling/ByteInput.
Warning: Could not register io.netty.handler.codec.marshalling.MarshallingEncoder: queryAllPublicMethods for reflection. Reason: java.lang.NoClassDefFoundError: org/jboss/marshalling/ByteOutput.

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

Additional context
Add any other context or screenshots about the feature request here.

@linghengqian linghengqian added the enhancement New feature or request label Oct 23, 2022
@sdeleuze
Copy link
Collaborator

I think the empty metadata are ok because those entries are just here to specify the exclude flag on metadata side and should not translate to concrete native-image.properties visible by the native image compiler. Maybe the builtin Netty files in https://github.com/netty/netty should be moved to proper io.netty/netty-* directories to not print those warnings.

Also native-image should not print those warnings on excluded dependencies.

@gradinac Any thoughts?

@gradinac
Copy link
Contributor

I think you are right, we should create the recommended metadata directory structure in Netty and move the metadata there, I'll create a Netty PR for that

@linghengqian
Copy link
Contributor Author

  • Looks like nothing needs to be done in this repository, I will close this issue.

@linghengqian linghengqian closed this as not planned Won't fix, can't repro, duplicate, stale Oct 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants