Skip to content
This repository has been archived by the owner on Feb 27, 2024. It is now read-only.

Cleanup route segment parsing #129

Open
AlexanderNull opened this issue May 11, 2020 · 0 comments
Open

Cleanup route segment parsing #129

AlexanderNull opened this issue May 11, 2020 · 0 comments

Comments

@AlexanderNull
Copy link

AlexanderNull commented May 11, 2020

RouteGenerator's parseRouteSegments is a bit unwieldy. We looked into scrapping it in general for 2.0 release however didn't have enough time to work around the somewhat rigid PathMatcher types from Akka-Http. PathMatcher classes are currently tied to objects typed explicitly by the number of matches a path needs to accomplish. As a result we end up having to maintain a lot of match statements which do nothing more than check the length of what's basically a collection of path segments.

Preferred state would be to get rid of the Holder case classes, and simply have a directive that returns a list of the path segment strings. Currently covered this up with paramHoldersToList method but would like to get rid of the more complected code in between.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant