From 1d9d9952ff12dbcc11cb37748e70559febf8c761 Mon Sep 17 00:00:00 2001
From: ebocher <erwan.bocher@cnrs.fr>
Date: Wed, 25 Sep 2024 17:10:42 +0200
Subject: [PATCH] New fix. I hope

---
 pom.xml                                               |  9 ---------
 src/main/java/module-info.java                        | 11 -----------
 .../java/org/orbisgis/demat/JavascriptEngine.java     | 10 +++++-----
 3 files changed, 5 insertions(+), 25 deletions(-)
 delete mode 100644 src/main/java/module-info.java

diff --git a/pom.xml b/pom.xml
index 6b18816..a2b184d 100755
--- a/pom.xml
+++ b/pom.xml
@@ -289,15 +289,6 @@
                         <doclint>all,-missing</doclint>
                         <quiet>true</quiet>
                     </configuration>
-                    <executions>
-                        <execution>
-                            <id>attach-javadocs</id>
-                            <phase>verify</phase>
-                            <goals>
-                                <goal>jar</goal>
-                            </goals>
-                        </execution>
-                    </executions>
                 </plugin>
                 <!-- Maven release generation -->
                 <plugin>
diff --git a/src/main/java/module-info.java b/src/main/java/module-info.java
deleted file mode 100644
index bbb80ba..0000000
--- a/src/main/java/module-info.java
+++ /dev/null
@@ -1,11 +0,0 @@
-module demat {
-    requires com.kitfox.svg;
-    requires data.api;
-    requires h2gis.utilities;
-    requires org.locationtech.jts;
-    requires com.fasterxml.jackson.databind;
-    requires java.sql;
-    requires com.caoccao.javet;
-    requires java.desktop;
-    requires com.j2html;
-}
\ No newline at end of file
diff --git a/src/main/java/org/orbisgis/demat/JavascriptEngine.java b/src/main/java/org/orbisgis/demat/JavascriptEngine.java
index 05c8160..5440a84 100755
--- a/src/main/java/org/orbisgis/demat/JavascriptEngine.java
+++ b/src/main/java/org/orbisgis/demat/JavascriptEngine.java
@@ -123,9 +123,8 @@ void initV8Engine() throws JavetException, IOException {
     /**
      * Save the vega-lite chart in a SVG file
      *
-     * @param outputFile
-     * @return
-     * @throws JavetException
+     * @param outputFile the file to store the result
+     * @return the absolute path of the file
      */
     public String saveSVG(String json, File outputFile, boolean delete) throws JavetException, IOException {
         if (outputFile.exists()) {
@@ -167,8 +166,9 @@ public String saveSVG(String json, File outputFile, boolean delete) throws Javet
      * Save the vega-lite chart in a PNG file
      *
      * @param outputFile
-     * @return
-     * @throws JavetException
+     * @param vega_spec the input vega spec
+     * @param outputFile the file to store the result
+     * @return the absolute path of the file
      */
     public String savePNG(String vega_spec, File outputFile, boolean delete, float ratio) throws JavetException {
         if (outputFile.exists()) {