Probably unnecessary Array copy #12856
samuelorji
started this conversation in
General
Replies: 2 comments
-
Please provide PR to fix this behaviour so :) |
Beta Was this translation helpful? Give feedback.
0 replies
-
Array is a mutable structure and it is not safe to assume that it won't change. |
Beta Was this translation helpful? Give feedback.
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
Hi,
Is there any reason why we can't call
ByteString.fromArrayUnsafe
here instead of callingapply
on ByteString which should save us an array copy .We already do
ByteString.fromArrayUnsafe
for theJsValue
writeable here.Beta Was this translation helpful? Give feedback.
All reactions