From e4c217917f4f55fd4c80e8313d39e410426034a7 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Sami=20M=C3=A4kinen?= Date: Tue, 15 Aug 2023 13:34:13 +0300 Subject: [PATCH] Reduce stack trace in logs by handling empty response from service --- .../java/org/oskari/service/wfs/client/OskariWFSClient.java | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/service-wfs-client/src/main/java/org/oskari/service/wfs/client/OskariWFSClient.java b/service-wfs-client/src/main/java/org/oskari/service/wfs/client/OskariWFSClient.java index 32752c289e..479e08f490 100644 --- a/service-wfs-client/src/main/java/org/oskari/service/wfs/client/OskariWFSClient.java +++ b/service-wfs-client/src/main/java/org/oskari/service/wfs/client/OskariWFSClient.java @@ -84,6 +84,9 @@ protected static SimpleFeatureCollection getFeatures(String endPoint, url = IOHelper.constructUrl(endPoint, query); responseHeaders = OskariWFSClient.readResponseTo(endPoint, user, pass, query, baos); response = baos.toByteArray(); + if (response.length == 0) { + throw new ServiceRuntimeException("Empty response from " + url); + } // TODO: Select parsing algorithm based on response headers (Content-Type) fc = parseGeoJSON(response, crs, url); if (fc != null) { @@ -105,6 +108,9 @@ protected static SimpleFeatureCollection getFeatures(String endPoint, baos.reset(); responseHeaders = OskariWFSClient.readResponseTo(endPoint, user, pass, query, baos); response = baos.toByteArray(); + if (response.length == 0) { + throw new ServiceRuntimeException("Empty response from " + url); + } fc = parseGML(response, crs, url, user, pass, gmlDecoder); if (fc != null) { return fc;