Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add check for unnecessary multipolygon relations #2191

Open
ziemek99 opened this issue Apr 5, 2024 · 3 comments
Open

Add check for unnecessary multipolygon relations #2191

ziemek99 opened this issue Apr 5, 2024 · 3 comments

Comments

@ziemek99
Copy link
Contributor

ziemek99 commented Apr 5, 2024

I've just fixed one of my old changesets (literally from my 2nd day of editing OSM) that I randomly remembered. Back then I was fiddling with iD since I had to split a landuse=grass way into two, but somehow I managed to create a multipolygon instead. I guess Osmose can check for such scenarios. If it detects a painfully simple multipolygon relation, just like my landuse=grass, with no other tags and a very simple geometry (no inner members, only outer), it might suggest splitting such unnecessary relation into its member ways. You can refer to changeset 149592903 to see what I mean.

@frodrigo
Copy link
Member

frodrigo commented Apr 5, 2024

There is already a report for 1-object multipolygon.

But I am not sure about report of union of simple polygon in multipolygon is a good move. I think such multipolygone can be used to "group" parts a common thing, like part of a named wood cut by a river.

@ziemek99
Copy link
Contributor Author

ziemek99 commented Apr 5, 2024

I think such multipolygone can be used to "group" parts a common thing, like part of a named wood cut by a river.

I know, hence the requirement of having no other tags. No names, no refs, just landuse=grass or any other tag (landuse=flowerbed maybe?) that isn't usually used either for bigger areas or for naming things. Maybe there is some named flowerbed that deserves naming in OSM, but most of them probably aren't and it's better to split any multipolygon with such tags for the sake of simplicity.

@Famlam
Copy link
Collaborator

Famlam commented Apr 7, 2024

I like the idea of flagging multipolygons with only 2 tags - type=multipolygon + landuse=* (at least when limited to physical land uses, like farmland or forest, thus excluding things like landuse=residential, industrial, ...) and only outer roles (which form more than 1 closed ring; multiple linear outers forming 1 ring are fine of course)

The risk is that e.g. a farmland was added as a multipolygon because it for example belongs to a single farmer, segregated by a road or so. However, these cases will very likely be very minimal. On the other hand, verification of such places would be very difficult, and that's holding me back from implementing it at the moment. Any thoughts on that?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants