Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

False positives in Italy for item 7150 class 12, Pharmacy without tag ref:msal or invalid #2223

Open
opk12 opened this issue May 17, 2024 · 1 comment

Comments

@opk12
Copy link

opk12 commented May 17, 2024

analyser_merge_pharmacy_IT.py and analyser_merge_parapharmacy_IT.py match pharmacies from a CSV dataset, based on ref:msal and the coordinates. There are false positives for the CSV rows that lack the coordinates, although OSM has the ref:msal. This is item 7150, class 12, Pharmacy without tag ref:msal or invalid.

For example, this pharmacy has this warning and this CSV row.

20851;00000;Via Sibilla Aleramo, 1/A;Farmacia Villavalle S.N.C.;03673141200;65012;068011;CEPAGATTI;Villareia;068;PE;PESCARA;130;ABRUZZO;01/09/2021;-;Ordinaria;1;-;-;2

It was suggested in the OSM Italy chat on May 9 that the dataset author (Ministero della Salute) is systematically omitting the coordinates for any newly added pharmacies.

@frodrigo
Copy link
Member

The issue is not with this analyser, but with the engine that remove data without location before the conflation.

Invalid geom should be keep for matching latter with ref

https://github.com/osm-fr/osmose-backend/blob/dev/analysers/Analyser_Merge.py#L1013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants