Exclude site relation multipolygon members from "Missing tag or role"

[sammyhawkrad]

According to Relation:site, the members are added without having to specify a role.

However, it appears that this does not apply to multipolygon members in https://github.com/osm-fr/osmose-backend/blob/master/analysers/analyser_osmosis_useless.py#L137 as it flags multipolygon members of site relations for missing tag or role.

Examples:

1. https://osmose.openstreetmap.fr/map/#level=3&item=1140&zoom=17&lat=7.4439077&lon=-2.5741419&level=3&tags=&fixable=&issue_uuid=895e4aa6-0b80-7b48-b578-8b491c08a87a
2. https://osmose.openstreetmap.fr/map/#level=3&item=1140&zoom=17&lat=7.443392&lon=-2.5742938&level=3&tags=&fixable=&issue_uuid=ae52f00d-3a70-d135-1dab-8137f27bb212
3. https://osmose.openstreetmap.fr/map/#level=3&item=1140&zoom=17&lat=7.4444908&lon=-2.5744951&level=3&tags=&fixable=&issue_uuid=a98d55f3-3626-1194-eb50-f20af1e96f42

[Marc-marc-marc]

looking at the 1st exemple, it's a wrong usage of a type=site relation : a site relation is not a collection of all objets (relation is not a collection) in an area related to one tag (operator, owner or whatelse) but for objets unable to be describe with a (closed) area
from wiki A site [relation](https://wiki.openstreetmap.org/wiki/Relation) is used to group several objects which together have a single identity as a whole but cannot be accurately described by other data types
here the "site" is described with the closed way

[sammyhawkrad]

I totally agree that the site relation is not correctly used in the examples I have shared. I have deleted a few of them with similar use recently. But the issue here is not really about "what" is mapped.

The real issue is that when a multipolygon is added to a site relation it gets flagged as not having a tag or role. The issue will still arise in cases where the site relation is correctly used.

[Famlam]

Item 1140, class 2
Can you give an example of such a valid case?

I can't think of many ways (no pun intended) how an untagged, outer way of a multipolygon is part of a site relation, but not the multipolygon (which contains the tags) itself.

[Marc-marc-marc]

by looking randomly, I've found at least 2 cases that shouldn't be causing a report but are doing so at the moment

• geodesic survey relation https://www.openstreetmap.org/relation/514927
• type=route should also be allowed to have empty role for way https://www.openstreetmap.org/relation/17815131