Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional persisters #110

Open
ottonemo opened this issue Jul 23, 2019 · 2 comments
Open

Additional persisters #110

ottonemo opened this issue Jul 23, 2019 · 2 comments

Comments

@ottonemo
Copy link
Contributor

I have written an S3 persister (FileIO and FileLike) based on s3fs and thought about making a PR (if you are interested) but I assume that you probably don't want a direct dependency to packages such as s3fs and boto3. Two questions:

  • are you interested in a PR at all
  • if so, how to integrate the S3 persister without cluttering the dependencies
@BenjaminBossan
Copy link

I believe it would make sense as completely optional dependency.

@dnouri
Copy link
Collaborator

dnouri commented Aug 26, 2019

We're already using setuptools extras for our optional dependencies to julia, rpy2, and others. I like the idea of adding a S3 persister to Palladium. We can even put it into persistence.py, as long as the case of not being able to import these dependencies is handled gracefully.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants