Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make it possible to build orchestrator with the race detector #178

Open
sjmudd opened this issue Mar 10, 2016 · 2 comments
Open

Make it possible to build orchestrator with the race detector #178

sjmudd opened this issue Mar 10, 2016 · 2 comments

Comments

@sjmudd
Copy link
Contributor

sjmudd commented Mar 10, 2016

This is a good thing as it allows you to see any code which might be partly broken when this is not apparent. Orchestrator does not generally use a lot of CPU so even running the binary with the race detector enabled has little overhead. Making it easy to do this by adjusting build.sh seems handy and basically requires the go build ... to be changed to go build -race ...

@shlomi-noach
Copy link
Contributor

As quick followup, @sjmudd tested and found that with -race there is a limit of 8192 concurrent goroutines. At @sjmudd 's workplace this is actually a reasonable number, hence -race si not applicable to his case.
It is therefore not applicable in the general case. I'm closing this.

@sjmudd
Copy link
Contributor Author

sjmudd commented Mar 11, 2016

Actually that error only happens if you have a very high concurrency. Most people should not see that, and in any case the idea was to have this as an optional build flag to build.sh, thus avoiding people having to adjust the build.sh to get a race-detector enabled binary. This would not be enabled normally but it would be useful as I have seen some races come up when running the stock orchestrator code with this enabled.

@shlomi-noach shlomi-noach reopened this Mar 11, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants