Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

By overriding headers bundle must be added to 'test' environment to make tests work #19

Open
danaki opened this issue May 31, 2018 · 2 comments

Comments

@danaki
Copy link

danaki commented May 31, 2018

Q A
Bug report? no
Feature request? yes
BC Break report? no
RFC? no
Version/Branch @dev

I overrided templates/headers like it's described in the documentation to support XSRF tokens via DunglasAngularCsrfBundle in GraphiQL. Now, when I run behat tests I'm getting this error:

In YamlFileLoader.php line 657:

  There is no extension able to load the configuration for "overblog_graphiql" (in /Users/yuri/work/ex/gql/config/packages/graphiql.yaml). Looked for namespace "overblog_graphiql", found "framework", "overblog_graphql", "twig", "doctrine_cache", "doctrine", "doctrine_migrations", "security", "stof_doctrine_extensions", "lexik_jwt_authentication", "nelmio_cors", "dunglas_angular_csrf", "overblog_graphql_types"

My config/packages/graphiql.yml looks like this:

overblog_graphiql:
    template: "GraphiQL/index.html.twig"

To fix this issue I was forced to add 'test' to the list of envs of GraphiQLBundle. This is not a big deal just wanted to let you know may be there is some kind of a better solution for this? Add 'test' to envs by default? Or fix documentation, may be config/packages/dev/graphiql.yml is more correct place for config (not completely sure if it works this way).

And may be overriding a service, writing a class to override headers is better than overriding GraphiQL twig templates (I was forced to code a Twig extension just to put this XSRF token to overriden template)?

@renatomefi
Copy link
Member

It seems to me you've done the right thing, by design we've put graphiql only on dev mode to avoid any kind of problems and security issues.
But since you're integrating it in your tests you have to allow symfony to configure it the way you did.

I personally never had to add it to my tests, if you come up with a better idea I'm willing to take a look!

@danaki
Copy link
Author

danaki commented May 31, 2018

Well, people usually don't need graphiql in their 'test' env, this is why I created this issue. Just because symfony finds an orphaned config it produces this error. There must be something to fix, may be documentation?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants