Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using -k with curl is insecure #234

Open
Sophira opened this issue May 8, 2016 · 0 comments
Open

Using -k with curl is insecure #234

Sophira opened this issue May 8, 2016 · 0 comments

Comments

@Sophira
Copy link

Sophira commented May 8, 2016

The README.md file suggests:

If you're the kind of shoot-from-the-hip brogrammer that doesn't mind
executing random scripts from the interwebs, then the easiest way to
install Emacs Live is to run the following which will safely preserve
any Emacs configs you already have:

bash <(curl -fksSL https://raw.github.com/overtone/emacs-live/master/installer/install-emacs-live.sh)

I understand why you might want to use curl and bash together, even though I don't agree with it. The part that I take issue with, however, is the use of the -k switch, which turns off certificate validation, so that even a certificate error will still cause it to succeed. This change was made in c4ca545, but I can't see a justification for it.

May I ask why this change was made? It negates one of the biggest points of using SSL in the first place and makes a MITM attack ridiculously easy. If someone has outdated certificates then they should be updating those first.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant