@tpatki Could you also please this squash this PR together into just a small set of clean commits?

You will also need to include appropriate autoconf checks since this will now only work with variorum 0.8 or newer.

@morrone
Thanks for the quick feedback! :)

Yes, I will squash into clean commits when we're done testing and when I mark this as ready for review (will be a few weeks until @kshoga1 can test on Mutt.)

You will also need to include appropriate autoconf checks since this will now only work with variorum 0.8 or newer.

Could you please clarify this? We were not checking for a specific version in configure.ac here earlier. Where/how should we include the autoconf checks (is there an example we can follow)?

Could you please clarify this? We were not checking for a specific version in configure.ac here earlier. Where/how should we include the autoconf checks (is there an example we can follow)?

Better than a specific version check is to test for features in the library that the code requires. For instance, are there some unique new function in the new version of the library? You could add a test for that function in the library.

LDMS's configure.ac has an AC_LIB_HAVE_LINKFLAGS test for variorum. There is an additional "testcode" field for that macro where you could put a tiny bit of C code that calls a function that is unique to the newer version of the code.

https://www.gnu.org/software/gnulib/manual/html_node/Searching-for-Libraries.html

@tpatki, @morrone what is the status of this PR?

Hi @tom95858 : This is draft PR at the moment. Kathleen (@kshoga1) will need to test this at scale internally. We plan to do that in this month. Once we have tested at scale, we'll address Chris' comments, update it as ready for review, and it can be merged.

@tpatki Ok great, thanks for the update.

@morrone, please confirm that this is not a target for 4.4.5.

@morrone, please confirm that this is not a target for 4.4.5.

Except for reviewing here, I'm not really involved in that work. But my understanding is that it'll happen when it happens, and we should not hold up the release for this work.

@tpatki please reopen this pull request when it is ready for review.