Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cray libfabric patch required for HPE EX40 systems #1472

Open
jennfshr opened this issue Oct 22, 2024 · 1 comment
Open

Cray libfabric patch required for HPE EX40 systems #1472

jennfshr opened this issue Oct 22, 2024 · 1 comment
Assignees
Labels
bug Build and RPMs Build and install. Source and RPMs
Milestone

Comments

@jennfshr
Copy link
Collaborator

Without this patch, configure cannot resolve cray's libfabric libs due to not looking in the lib64 directory. I haven't spent time trying to make this flexible and look both in lib and lib64, and I don't see this piece whatsoever in OVIS-4.

That said, some work or guidance to conditionally define it or dynamically resolve the lib dir name in the configure.ac will need to be fashioned as a solution here.

diff --git a/configure.ac b/configure.ac
index 13f0a862..ddcaa6e1 100644
--- a/configure.ac
+++ b/configure.ac
@@ -189,10 +189,10 @@ dnl we need libibverbs-devel and librdmacm-devel to support rdma
   if test "\$enable_fabric" = "yes"; then
     AC_ARG_WITH([libfabric],
       AC_HELP_STRING([--with-libfabric], [Specify libfabric location]),
-        [AS_IF([test -d "\$withval/lib"], [LIB_FABRIC="\$withval"],
+        [AS_IF([test -d "\$withval/lib64"], [LIB_FABRIC="\$withval"],
           AC_MSG_ERROR([libfabric not found at \$withval]))],
           AC_MSG_ERROR([must specify --with-libfabric]))
-    LDFLAGS="\$LDFLAGS -L\${LIB_FABRIC}/lib"
+    LDFLAGS="\$LDFLAGS -L\${LIB_FABRIC}/lib64"
     AC_SUBST([LIBFABRIC_INCDIR], [\${LIB_FABRIC}/include])
     saveCPPFLAGS=\$CPPFLAGS
     CPPFLAGS="\$CPPFLAGS -I\${LIB_FABRIC}/include"
@jennfshr jennfshr added bug Build and RPMs Build and install. Source and RPMs labels Oct 22, 2024
@jennfshr jennfshr added this to the v4.4.5 milestone Oct 22, 2024
@jennfshr jennfshr self-assigned this Oct 22, 2024
morrone pushed a commit to morrone/ldms that referenced this issue Oct 22, 2024
`--with-libfabric` was only looking for the library in `PREFIX/lib`.
This patch removed `--enable-fabric` and use `--with-fabric` that check
for the library/header by default.

Fixes ovis-hpc#1472
tom95858 pushed a commit that referenced this issue Oct 22, 2024
`--with-libfabric` was only looking for the library in `PREFIX/lib`.
This patch removed `--enable-fabric` and use `--with-fabric` that check
for the library/header by default.

Fixes #1472
@morrone
Copy link
Collaborator

morrone commented Oct 23, 2024

@jennfshr please let us know if the latest b4.4 address that build problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Build and RPMs Build and install. Source and RPMs
Projects
None yet
Development

No branches or pull requests

2 participants