Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recently landed PR #1490 breaks static decomposition default ("fill") string #1495

Open
morrone opened this issue Nov 1, 2024 · 3 comments

Comments

@morrone
Copy link
Collaborator

morrone commented Nov 1, 2024

Recently landed PR #1490 breaks static decomposition. Here's the error that I am seeing:

Nov 01 15:35:52 hetchy14 ldmsd[263393]: Fri Nov 01 15:35:52 2024: ERROR     : strgp 'kafka.label_ibmad': row '0': col[dst] 'cluster','fill' error 22: Unsupported JSON value.
Nov 01 15:35:52 hetchy14 ldmsd[263393]: Fri Nov 01 15:35:52 2024: ERROR     : msg_no 67: error 22: strgp 'kafka.label_ibmad': row '0': col[dst] 'cluster','fill' error 22: Unsupported JSON value.
Nov 01 15:35:52 hetchy14 ldmsd[263393]: Fri Nov 01 15:35:52 2024: ERROR     : Configuration error at line 67 (/etc/ldmsd/[email protected])
Nov 01 15:35:52 hetchy14 ldmsd[263393]: Fri Nov 01 15:35:52 2024:           : LDMSD_ LDMS Daemon exiting...status 22, Error 22 processing configuration file '/etc/ldmsd/[email protected]'
Nov 01 15:35:52 hetchy14 ldmsd[263393]: Fri Nov 01 15:35:52 2024:           : LDMSD_ cleanup end.

And this almost certainly is due to this line:

                        {"src":"cluster", "dst":"cluster", "type":"char_array", "array_len":12, "fill":"hetchy"},

Probably there should be tests of all default fill types. If it broke this, it may have broken other default fills as well.

@morrone morrone changed the title Recently landed PR#1490 breaks static decomposition default ("fill") string Recently landed PR #1490 breaks static decomposition default ("fill") string Nov 1, 2024
@tom95858
Copy link
Collaborator

tom95858 commented Nov 2, 2024

@narategithub it looks like we may have missed a type or two, or we inadvertently changed a type name?

@tom95858
Copy link
Collaborator

tom95858 commented Nov 2, 2024

@morrone, thanks for helping test this.

@narategithub
Copy link
Collaborator

@morrone thanks for catching this. I'm updating the test script to include all "fill" types & fixing the fill.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants