Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SOS libraries should be combined and renamed #27

Open
tom95858 opened this issue Aug 25, 2020 · 2 comments
Open

SOS libraries should be combined and renamed #27

tom95858 opened this issue Aug 25, 2020 · 2 comments

Comments

@tom95858
Copy link
Collaborator

Hi @morrone, @baallan,

The SOS libraries need to be moved to $pkglibdir and renamed to avoid collision with existing libraries.

I am fairly certain that RHEL, at least, has a libsos library already. If $pkglibdir is /usr/lib[64] this will cause collisions with -lsos.

If we are not satisfied with requiring -L$pkglibdir/sos -lsos or something like (we have already litigated the inevitability of library name collision discussion) then libsos needs a new name. SOS is independent of LDMS/OVIS so libldms_sos, etc... gives me pause.

I'll need to propose a new name that is unique and doesn't give the undue impression of dependency. But overall, I think we are at:

$pkglibdir/lib[new_name].so
$pkglibdir/[new_name]_plugins

@baallan
Copy link
Collaborator

baallan commented Aug 25, 2020

@tom95858 I thought you had already shifted to sosdb for packaging. That seems fine for lib name too. Though by convention if the configure.ac package is sosdb, then (e.g. rhel)
libdir is /usr/lib64 and pkglibdir is /usr/lib64/sosdb.

@tom95858
Copy link
Collaborator Author

Hi @baallan, yes libsosdb.so seems like a reasonable name

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants