Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove interfaceToOVSDBNotationInterface #149

Closed
dave-tucker opened this issue Jun 9, 2021 · 0 comments · Fixed by #184
Closed

Remove interfaceToOVSDBNotationInterface #149

dave-tucker opened this issue Jun 9, 2021 · 0 comments · Fixed by #184
Labels

Comments

@dave-tucker
Copy link
Collaborator

Depends on #116

We should look at using OvsToNative instead. This wasn't done in the original PR as I couldn't figure out how to get the ColumnSchema to be available when marshalling to a struct from JSON.

The alternative to point_up was to indirect access to the value using Value(schema *ColumnSchema) which would convert it, but I disregarded that but because you could use the wrong ColumnSchema AND you had to use NewCondition/Mutation directly and couldn't quickly create instances of the struct.
The other big issue with OvsToNative apart from needing the ColumnSchema was that it assumes sensible types, and doesn't support the "interesting" types we get from the back from the JSON Parser. E.g []interface{}{"set", []interface{}{[]interface{}{"named-uuid", "foo"}, []interface{}{"named-uuid", "bar"}}}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant