Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

delete or un-multitenant TestTenantStatementTimeoutAdmissionQueueCancelation #9

Open
iliana opened this issue Oct 21, 2024 · 0 comments
Labels
cleanup Nice-to-have cleanup work but not urgent

Comments

@iliana
Copy link
Collaborator

iliana commented Oct 21, 2024

// TestTenantStatementTimeoutAdmissionQueueCancelation tests that a KV request
// that is canceled via a statement timeout is properly removed from the
// admission control queue. A testing filter is used to "park" a small number of
// requests thereby consuming those CPU "slots" and testing knobs are used to
// tightly control the number of entries in the queue so that we guarantee our
// main statement with a timeout is blocked.
func TestTenantStatementTimeoutAdmissionQueueCancelation(t *testing.T) {
defer leaktest.AfterTest(t)()
skip.IgnoreLint(t, "tenant connector requires a CCL binary")

Not immediately clear to me if this test is testing something we otherwise wouldn't be if we deleted it.

@iliana iliana added the cleanup Nice-to-have cleanup work but not urgent label Oct 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup Nice-to-have cleanup work but not urgent
Projects
None yet
Development

No branches or pull requests

1 participant