Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Could we be more helpful when response deserialization breaks? #280

Open
Aaron-Hartwig opened this issue Sep 20, 2024 · 0 comments
Open

Comments

@Aaron-Hartwig
Copy link
Contributor

This is rather unsporting:

root@oxz_switch0:~# xcvradm -i sidecar0 -t 0 vendor-info
Error: Failed to fetch vendor information for transceiver modules

Caused by:
    0: Controller protocol error
    1: Serialization failed

Can we be more helpful here? This port did not have a module installed at all, so the SP responded with a HwError::NotPresent, but this old version of Dendrite couldn't map that byte to a HwError.

This can happen when Dendrite's transceiver-messages is behind where the SP's is. So technically we handled this error and reported what we saw, but that isn't helpful. Most of the time when we've seen this thus far it is because we added a new HwError variant. In the case where our response size matches the size we expect, I think it would be helpful if we could just dump out the bytes that we can't decode.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant