Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

required keyword on a $ref causes a not yet implemented panic #533

Closed
kika opened this issue Mar 24, 2024 · 1 comment · Fixed by #543
Closed

required keyword on a $ref causes a not yet implemented panic #533

kika opened this issue Mar 24, 2024 · 1 comment · Fixed by #543

Comments

@kika
Copy link

kika commented Mar 24, 2024

Seems similar to #272 and #312

The relevant portion of the schema looks like this:

{
  "$schema": "http://json-schema.org/draft-04/schema#",
  "definitions": {
    "somename": {
      "$ref": "#/definitions/someothername",
      "required": [
        "someproperty"
      ]
    }
  }
}

Indeed SchemaObject type doesn't have a required field, which is only valid on object type as per spec. And at the time of the parse it's unknown what $ref points to.
I'm willing to hack on this, but don't see how to do about it with the current codebase.

@SRetip SRetip mentioned this issue Apr 1, 2024
@kika
Copy link
Author

kika commented Apr 3, 2024

related: #523

@ahl ahl closed this as completed in #543 Apr 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant