Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependency on regress should be configurable #682

Open
thomasmost opened this issue Oct 10, 2024 · 3 comments
Open

Dependency on regress should be configurable #682

thomasmost opened this issue Oct 10, 2024 · 3 comments

Comments

@thomasmost
Copy link

Settings should include either a with_regress_converters or a without_regress_converters setter so that a dependency on regress is not guaranteed.

Perhaps a smaller version of this could be configuring the tool to generate struct definitions alone, without any converters.

@ahl
Copy link
Collaborator

ahl commented Oct 10, 2024

That's an interesting idea. Is the objection to regress that its a large dependency? What would you propose we do to validate string formats if we didn't have that dependency? In stand-alone, generated crates, I believe we only include the regress dependency when it's actually needed.

@thomasmost
Copy link
Author

Yes, it's a large dependency and I think there's value to generating bindings that can be used without making assumptions about validation strategy.

That said this is just one man's request for a more custom-izable library :) overall the utility is still fantastic!

@thomasmost
Copy link
Author

thomasmost commented Nov 8, 2024

Oh, here's a question, if I don't set with_struct_builder(true)); — does that eliminate the regress dependency?

Update

Looks like no haha

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants