Testing: git push auto fixed files #4160
Conversation
…oxsecurity#4142) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
…ecurity#4155) * [automation] Auto-update linters version, help and documentation * [MegaLinter] Apply linters fixes --------- Co-authored-by: nvuillam <[email protected]>
lukelloyd1985
requested review from
nvuillam,
echoix,
bdovaz and
Kurt-von-Laven
as code owners
| @@ -63,6 +64,11 @@ def produce_report(self): | |||
| f" in folder {updated_sources_dir}.\n" | |||
| "Download it from artifacts then copy-paste it in your local repo to apply linters updates" | |||
| ) | |||
|
|
|||
| repo = git.Repo(os.path.realpath(self.github_workspace)) | |||
There was a problem hiding this comment.
Do that only if APPLY_FIXES = all , or matches the linter :)
- self.master will give you the Linter instance
- self.master.master will give you the MegaLinter instance
- so self.master.master.github_workspace will work :)
Also, check if you are on GitHub: if you are, don't make git operation, as they are already defined in the next GitHub Action :) ( if it works, we can deprecate it in a next major version)
There was a problem hiding this comment.
how to check the git platform being used?
There was a problem hiding this comment.
if GITHUB_REPOSITORY is set, you're on GitHub actions :)
There was a problem hiding this comment.
think I've catered for both of those now? 🤞
| repo = git.Repo(os.path.realpath(self.github_workspace)) | ||
| repo.git.add(update=True) | ||
| repo.index.commit("megalinter auto fixes") | ||
| repo.git.push |
There was a problem hiding this comment.
Also add try except, I don't want the whole MegaLinter to crash in case UpdatedSourcesReporter crashes, I prefer to just have a warning message ^^
There was a problem hiding this comment.
put a try except around which will hopefully give the correct git error message as I can't imagine this is going to work first attempt 😆
| apply_fixes = config.get_list(self.request_id, "APPLY_FIXES", "none") | ||
| if apply_fixes: | ||
| try: | ||
| repo = git.Repo(os.path.realpath(self.master.master.github_workspace)) |
There was a problem hiding this comment.
sorry, master is MegaLinter instance, so it will be self.master.github_workspace :)
| @@ -63,6 +64,16 @@ def produce_report(self): | |||
| f" in folder {updated_sources_dir}.\n" | |||
| "Download it from artifacts then copy-paste it in your local repo to apply linters updates" | |||
| ) | |||
|
|
|||
| apply_fixes = config.get_list(self.request_id, "APPLY_FIXES", "none") | |||
There was a problem hiding this comment.
I overlooked that 🤦♂️ good catch 👍
|
@nvuillam, how come the PR got closed rather than merged? Did I do something wrong? |
|
@lukelloyd1985 I played with alpha to solve CI issues (which are still not solved, damn docker !) So I deleted and recreated (then merged alpha), I think your PR has been closed when I deleted alpha branch to recreate it , sorry you can reopen it ! :) |
Need a new alpha branch by the looks of it :) |
|
@lukelloyd1985 created :) |
Proposed Changes
Testing git add, commit & push when there are fixed sources files
Readiness Checklist
Author/Contributor
Reviewing Maintainer
breakingif this is a large fundamental changeautomation,bug,documentation,enhancement,infrastructure, orperformance