Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Beta] AzureCommentReporter fails when target repo contains spaces #4184

Open
lukelloydagi opened this issue Oct 23, 2024 · 0 comments · May be fixed by #4185
Open

[Beta] AzureCommentReporter fails when target repo contains spaces #4184

lukelloydagi opened this issue Oct 23, 2024 · 0 comments · May be fixed by #4185
Labels
bug Something isn't working

Comments

@lukelloydagi
Copy link

Describe the bug
Following #4132 being resolved in beta branch I've been doing some additional testing and found it still fails in the PR target repository contains spaces

Expected behavior
PR comment to be created on PR target repos that contain spaces

Screenshots
image

Additional context
The SYSTEM_PULLREQUEST_SOURCEREPOSITORYURI environment variable will pass the target repository name with %20 URL encoding instead of spaces so these need to be replaced to get the correct repository name.
@lukelloydagi lukelloydagi added the bug Something isn't working label Oct 23, 2024
@lukelloyd1985 lukelloyd1985 linked a pull request Oct 23, 2024 that will close this issue
Open
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix AzureCommentReporter where repo names contain spaces lukelloyd1985/megalinter
1 participant
@lukelloydagi