Fix AzureCommentReporter where repo names contain spaces #4185
+3
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukelloyd1985
requested review from
nvuillam,
echoix,
bdovaz and
Kurt-von-Laven
as code owners
echoix
reviewed
Oct 23, 2024
| @@ -116,7 +116,7 @@ def produce_report(self): | |||
| + "See https://learn.microsoft.com/en-us/azure/devops/pipelines/" | |||
| + "build/variables?view=azure-devops&tabs=yaml" | |||
| ) | |||
| repository_name = SYSTEM_PULLREQUEST_SOURCEREPOSITORYURI.split("/")[-1] | |||
| repository_name = SYSTEM_PULLREQUEST_SOURCEREPOSITORYURI.split("/")[-1].replace('%20', ' ') | |||
There was a problem hiding this comment.
Is it only spaces that need to be encoded? Or a general urlencoding should be used?
There was a problem hiding this comment.
It's more decoding from the URL and spaces should be sufficient based on the ADO imposed restrictions?
There was a problem hiding this comment.
Just double checked and periods (.) & underscores (_) are within the URL so will work so think it's just the spaces
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4184
Proposed Changes
When using
SYSTEM_PULLREQUEST_SOURCEREPOSITORYURIvariable any repositories that have spaces in the name will need the%20URL encoded space converted back to a space.Readiness Checklist
Author/Contributor
Reviewing Maintainer
breakingif this is a large fundamental changeautomation,bug,documentation,enhancement,infrastructure, orperformance