Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: toggle curl #40

Open
oysandvik94 opened this issue Aug 26, 2024 · 0 comments · May be fixed by #53
Open

feature: toggle curl #40

oysandvik94 opened this issue Aug 26, 2024 · 0 comments · May be fixed by #53
Labels
enhancement New feature or request

Comments

@oysandvik94
Copy link
Owner

I buried myself in to a hole by creating 4 open methods in the API. If I want to create toggles, I need to create 4 equivalent toggle methods, which feels like cluttering the API.

Options:

  1. Add flags to the method for toggling toggle. This feels bad, since the name of the api method is no longer appropriate
  2. Only add toggle methods for CurlOpen and CurlOpen global, since the other functions maybe does not make too much sense to toggle. Here we can also add an api method to see whether curl is open, so users can create their own toggle methods
@oysandvik94 oysandvik94 added the enhancement New feature or request label Aug 26, 2024
oysandvik94 added a commit that referenced this issue Sep 26, 2024
@oysandvik94 oysandvik94 linked a pull request Sep 26, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant