Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

running on windows throws error because windows doesn't have "uname" command #31

Closed
nomad-scl opened this issue Jan 28, 2023 · 2 comments · Fixed by #32
Closed

running on windows throws error because windows doesn't have "uname" command #31

nomad-scl opened this issue Jan 28, 2023 · 2 comments · Fixed by #32

Comments

@nomad-scl
Copy link

trying to run tui in windows throws an error because in crossterm/src/java/tui/crossterm/NativeLoader.java the getPlatform function tries to run the unix/linux command "uname" which doesn't exist in windows
@oyvindberg
Copy link
Owner

Hi there!

Ohhh, right. I remember I was a bit sceptic while porting that code when I saw it ran uname, but since I had recently learnt that at least newer windowses actually do have the uname command I figured it had to work. So that code is ported to java from sbt-jni, and now I found sbt/sbt-jni#20 .

oyvindberg added a commit that referenced this issue Jan 31, 2023
@oyvindberg
Fix broken platform detection
2353274 
- this also changes the platform suffix for windows from `x86_64-msys_nt-10.0-20348` to `x86_64-windows`

Fixes #31
@oyvindberg oyvindberg mentioned this issue Jan 31, 2023
Merged
oyvindberg added a commit that referenced this issue Jan 31, 2023
@oyvindberg
Fix broken platform detection (#32)
cc21d7a 
* Fix broken platform detection

- this also changes the platform suffix for windows from `x86_64-msys_nt-10.0-20348` to `x86_64-windows`

Fixes #31

* understand more arch options

* exception handling
@oyvindberg
Copy link
Owner

released 0.0.5 with the fix. I honestly haven't tested it as good as I should, but it passed CI on all four supported platforms

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix broken platform detection oyvindberg/tui-scala
2 participants
@oyvindberg @nomad-scl