Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LN-DLC: Allow force-close at any point #113

Closed
luckysori opened this issue Jun 19, 2023 · 1 comment
Closed

LN-DLC: Allow force-close at any point #113

luckysori opened this issue Jun 19, 2023 · 1 comment
Assignees
Labels

Comments

@luckysori
Copy link
Collaborator

We must let consumers trigger force-close at any point in the protocol.

I think we will need to handle some states differently. For instance, with an Offered state I think we would need to fall back to the previous commitment transaction (sans split transaction), whereas with CloseConfirmed we would need to use the newly negotiated state (sans split transaction too).

I open this issue because of this check which ensures that the subchannel is in the Signed state:

let (mut signed, state) = get_sub_channel_in_state!(
self.dlc_channel_manager,
*channel_id,
Signed,
None::<PublicKey>
)?;

@luckysori
Copy link
Collaborator Author

I think this whole issue has finally been addressed with #128.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

No branches or pull requests

2 participants