Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New protobuf entities should have a comment of the form "Added in x.y.z" #441

Closed
smolkaj opened this issue Jul 18, 2023 · 2 comments
Closed

New protobuf entities should have a comment of the form "Added in x.y.z" #441

smolkaj opened this issue Jul 18, 2023 · 2 comments

Comments

@smolkaj
Copy link
Member

smolkaj commented Jul 18, 2023 •
edited
Loading

Context: #432 (comment)

I propose that going forward, when adding new fields/messages/services to our P4Runtime protobuf schemas, we always include comments such as

// Added in 1.4.0.

This allows developers to reason about forward/backward compatibility of various sever/client combinations when the server and client may be using different versions of the protobuf schemas.

@jafingerhut @chrispsommers WDYT?
@smolkaj smolkaj mentioned this issue Jul 18, 2023
Merged
@chrispsommers
Copy link
Collaborator

Seems like a good ideato me!

@jafingerhut
Copy link
Contributor

Agreed

@jafingerhut jafingerhut mentioned this issue Aug 13, 2023
Merged
@smolkaj smolkaj closed this as completed May 6, 2024
@smolkaj smolkaj mentioned this issue May 10, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jafingerhut @smolkaj @chrispsommers