Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation/process for adding new callbacks #1390

Open
AndrewFasano opened this issue Dec 1, 2023 · 0 comments
Open

Documentation/process for adding new callbacks #1390

AndrewFasano opened this issue Dec 1, 2023 · 0 comments

Comments

@AndrewFasano
Copy link
Member

It used to be fairly straightforward to add a new callback, for example:
95fb1a9. We would:

  • Add to cb-defs.h enum + docs and signature
  • Add 1-line macro to cb-support.c
  • Execute the self-updating cb-support.h script and pypanda's create_datatypes.py scripts

Since merging #1105 this process has gotten a bit more complex and I couldn't find any documentation. I managed to successfully add a callback on a branch here (it doesn't do anything, but it builds)
ac62025. This issue can be a placeholder for documentation, but we should write some docs and/or remove all the unnecessary manual effort with the context-based headers!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant