Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature]: support configurable I/O space to drain at a time in edge-triggered mode #643

Closed
panjf2000 opened this issue Oct 25, 2024 · 0 comments · Fixed by #646
Closed
Assignees
Labels
enhancement New feature or request pending development Requested PR owner to improve code and waiting for the result proposal accepted Proposal has been accepted proposal Proposal for this repo
Milestone

Comments

@panjf2000
Copy link
Owner

Description of new feature

Add a new option that specifies the number of bytes that gnet can read/write up to in one event loop of ET. For the moment, the default is 1MB.

Scenarios for new feature

It would be useful when users need to read/write more (or less) data in one event loop of ET.

Breaking changes or not?

No

Code snippets (optional)

type Options struct {
	...

	// EdgeTriggeredIOSpace specifies the number of bytes that `gnet` can 
	// read/write up to in one event loop of ET. The default is 1MB.
	EdgeTriggeredIOSpace int
}

Alternatives for new feature

None.

Additional context (optional)

None.

@panjf2000 panjf2000 added enhancement New feature or request proposal Proposal for this repo labels Oct 25, 2024
@panjf2000 panjf2000 added this to the v2.6 milestone Oct 25, 2024
@panjf2000 panjf2000 self-assigned this Oct 25, 2024
@panjf2000 panjf2000 added pending development Requested PR owner to improve code and waiting for the result proposal accepted Proposal has been accepted labels Oct 25, 2024
lovefyf928 pushed a commit to lovefyf928/gnet that referenced this issue Oct 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request pending development Requested PR owner to improve code and waiting for the result proposal accepted Proposal has been accepted proposal Proposal for this repo
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant