feat: support configurable I/O space to drain at a time in edge-trigg… #644
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
panjf2000
reviewed
Oct 30, 2024
gnet.go
Outdated
| @@ -418,6 +418,8 @@ func (*BuiltinEventEngine) OnTick() (delay time.Duration, action Action) { | |||
| // MaxStreamBufferCap is the default buffer size for each stream-oriented connection(TCP/Unix). | |||
| var MaxStreamBufferCap = 64 * 1024 // 64KB | |||
|
|
|||
| var DefaultEdgeTriggeredIOSpace = 1 << 20 | |||
There was a problem hiding this comment.
Add a comment for this new exported variable.
panjf2000
reviewed
Oct 30, 2024
eventloop_unix.go
Outdated
| @@ -152,7 +150,7 @@ loop: | |||
| _, _ = c.inboundBuffer.Write(c.buffer) | |||
| c.buffer = c.buffer[:0] | |||
|
|
|||
| if c.isEOF || (isET && recv < maxBytesTransferET) { | |||
| if c.isEOF || (isET && recv < el.engine.opts.EdgeTriggeredIOSpace) { | |||
There was a problem hiding this comment.
Declare a new local variable for this, like isET.
panjf2000
reviewed
Oct 30, 2024
options.go
Outdated
| @@ -268,3 +272,10 @@ func WithEdgeTriggeredIO(et bool) Option { | |||
| opts.EdgeTriggeredIO = et | |||
| } | |||
| } | |||
|
|
|||
| // WithEdgeTriggeredIOSpace set number of bytes that gnet can read/write up to in one event loop of ET. | |||
There was a problem hiding this comment.
// WithEdgeTriggeredIOSpace sets the number of bytes that gnet can read/write up to in one event loop of ET.
panjf2000
requested changes
Oct 30, 2024
|
I haven't got a response to my request about adding new tests for almost a week, so I've created #646, thank you for the efforts here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ered mode(#643)
1. Are you opening this pull request for bug-fixes, optimizations or new feature?
new feature
2. Please describe how these code changes achieve your intention.
在eventloop_unix.go中将read/write函数中以前的maxBytesTransferET移除变更为了配置的值，对EdgeTriggeredIOSpace配置进行了初始化。
3. Please link to the relevant issues (if any).
#643
4. Which documentation changes (if any) need to be made/updated because of this PR?
4. Checklist