Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support timeout when Dial #665

Closed
wants to merge 1 commit into from
Closed

Conversation

tyws
Copy link

@tyws tyws commented Dec 13, 2024

1. Are you opening this pull request for bug-fix, optimization or new feature?

new feature

2. Please describe how these code changes achieve your intention.

add new functions use net.DialTiemout to create connection

3. Please link to the relevant issues (if any).

4. What documentation changes (if any) need to be made/updated because of this PR?

4. Checklist

  • I have squashed all insignificant commits.
  • I have commented my code for explaining package types, values, functions, and non-obvious lines.
  • I have written unit tests and verified that all tests passes (if needed).
  • I have documented feature info on the README (only when this PR is adding a new feature).
  • (optional) I am willing to help maintain this change if there are issues with it later.

@panjf2000
Copy link
Owner

Thank you for the PR! But I'm not sure we need this feature. If the users want to dial with a timeout, they can call net.DialTimeout to get the net.Conn and pass it to Client.Enroll.

@tyws tyws closed this Dec 16, 2024
@tyws tyws deleted the support-dial-timeout branch December 16, 2024 02:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants