Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(sdk): Signature abstraction #11567

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

chore(sdk): Signature abstraction #11567

wants to merge 4 commits into from
+168 −0

Conversation

emhane
Copy link
Member

@emhane emhane commented Oct 8, 2024

Closes #11566

@emhane emhane added C-debt Refactor of code section that is hard to understand or maintain A-sdk Related to reth's use as a library labels Oct 8, 2024
@github-actions github-actions bot added the A-op-reth Related to Optimism and op-reth label Oct 8, 2024
@emhane emhane marked this pull request as draft October 8, 2024 11:31
@emhane emhane marked this pull request as ready for review October 8, 2024 12:06
This was referenced Oct 8, 2024
Open
Open
Rjected
Rjected reviewed Oct 8, 2024
View reviewed changes
Copy link
Member

@Rjected Rjected left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

when would the user configure this? i.e., why do we need a signature trait? Additionally the trait methods seem to be specific to ethereum compatible secp256k1 signatures, in those cases I would just use the concrete Signature struct

@Rjected
Copy link
Member

Rjected commented Oct 8, 2024

ah, I see, so specifically this is supposed to abstract around the op deposit transaction hacks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rjected Rjected Rjected left review comments

@joshieDo joshieDo Awaiting requested review from joshieDo joshieDo is a code owner

@gakonst gakonst Awaiting requested review from gakonst gakonst is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
A-op-reth Related to Optimism and op-reth A-sdk Related to reth's use as a library C-debt Refactor of code section that is hard to understand or maintain
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Define trait Signature
2 participants
@emhane @Rjected