Override EthTransactions::transaction_by_hash for OpApi

[mattsse]

Describe the feature

ref #11164
for OP deposits we need to fetch the receipt as well,

since EthTransactions only delegates

reth/crates/rpc/rpc-eth-api/src/helpers/transaction.rs

Line 67 in 6295459

fn transaction_by_hash(

we can easily override this and if there's deposit we need to set the nonce and depositversion accordingly

Additional context

No response

[emhane]

don't see how this will solve the problem of #11440, because the return type of that method doesn't return the rpc transaction type. the problem is filling the rpc response with the consensus tx type + block info + op extra metadata.

[aroralanuk]

Maybe I'm missing some context here, but can we extend RpcTransaction for optimism like below:

pub enum ExtendedRpcTransaction<T> {
    Base(RpcTransaction<T>),
    Optimism(OptimismRpcTransaction<T>),
}
...

async fn transaction_by_hash(
    &self,
    hash: B256,
) -> RpcResult<Option<ExtendedRpcTransaction<T::NetworkTypes>>> {
    let transaction_option = EthTransactions::transaction_by_hash(self, hash).await?;
    if let Some(tx) = transaction_option {
        let receipt_option = EthTransactions::transaction_receipt(self, hash).await?;
        let is_deposit = tx.is_deposit();
        let (deposit_nonce, deposit_receipt_version) = if is_deposit {
            if let Some(receipt) = receipt_option {
                (
                    receipt.deposit_nonce,
                    receipt.deposit_receipt_version,
                )
            } else {
                (None, None)
            }
        } else {
            (None, None)
        };
        
        if is_deposit {
            let optimism_rpc_tx = OptimismRpcTransaction::new(
                tx,
                ...
                deposit_nonce,
                deposit_receipt_version,
            );

            Ok(Some(optimism_rpc_tx.into()))
        } else {
            Ok(Some(ExtendedRpcTransaction::from(base_rpc_tx)))
        }
    } else {
        Ok(None)
    }
}

[emhane]

changing the signature of EthTransactions::transaction_by_hash to return the rpc tx instead, and changing the impl of EthApiServer accordingly, allows to add despot receipt version field in op impl of EthTransactions