Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make server connection read/write robust to partial message read/write #23

Open
jn9e9 opened this issue Feb 10, 2021 · 0 comments
Open
Labels
bug Something isn't working small Effort label

Comments

@jn9e9
Copy link
Collaborator

jn9e9 commented Feb 10, 2021

currently interfaces/operations/operations_client.go Client.operation() assumes that the whole of a request is successfully written to the output writer in one go, whereas the write api allows for only part of the buffer to be written in any one transaction.

On the read side, for the response, it also assumes that the whole of the response is received in one go. It also does not copy with resynchronisation to find a new header magic number if it finds itself in a confused state

@jn9e9 jn9e9 added bug Something isn't working small Effort label labels Feb 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working small Effort label
Projects
None yet
Development

No branches or pull requests

1 participant