Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wireheader improvements to prepare for potential wire header changes #31

Open
jn9e9 opened this issue Mar 4, 2021 · 0 comments
Open
Labels
enhancement New feature or request small Effort label

Comments

@jn9e9
Copy link
Collaborator

jn9e9 commented Mar 4, 2021

Note that the first four fields:

  • magic number
  • header size
  • major version number
  • minor version number

will always have the same width and position on every Parsec request/response header, no matter the wire protocol version. It would then make sense to either separate them in their own structure or not include them in the wireHeader structure, which will be the one that is versioned. In the Rust interface, we put the rest in its own wire_header_1_0 module to make it easy to write the logic selecting the correct wire header format. Though we did not implement that logic yet, at least we have the building blocks 😋 you have some more info here

Originally posted by @hug-dev in #28 (comment)

Also consider this comment: #28 (comment)

@jn9e9 jn9e9 changed the title Consider partitioning wireheader into immutable and version specific structures Wireheader improvements to prepare for potential wire header changes Mar 4, 2021
@jn9e9 jn9e9 added enhancement New feature or request small Effort label labels Mar 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request small Effort label
Projects
None yet
Development

No branches or pull requests

1 participant