Skip to content
This repository has been archived by the owner on Sep 14, 2023. It is now read-only.

Deno version checks #820

Closed
wirednkod opened this issue Mar 29, 2023 · 8 comments
Closed

Deno version checks #820

wirednkod opened this issue Mar 29, 2023 · 8 comments
Labels

Comments

@wirednkod
Copy link
Contributor

wirednkod commented Mar 29, 2023

Feature Request

It would nice to have some checks on which Deno version should be used in order for CAPI to work;

Suggestion

~ deno 
Deno 1.27.1

~ deno task run ./examples/balance.ts
Task run deno task capi -- deno run -A -r=http://localhost:4646/ "./examples/balance.ts"
Task capi deno run -A main.ts "--" "deno" "run" "-A" "-r=http://localhost:4646/" "./examples/balance.ts"
error: Unstable use of npm specifiers. The --unstable flag must be provided.

Additional message proposal:

Use deno 1.xxx for better compatibility with CAPI

or

CAPI supports deno versions >= 1.xxx

Motivation

Trying to run examples with CAPI repo - resulted to the error above - once upgraded to latest version, error disappeared

Use Cases

@tjjfvi
Copy link
Contributor

tjjfvi commented Mar 29, 2023

There's not really a way for us to detect this as this is an error from Deno during the caching phase, before any of our code is run.

@tjjfvi tjjfvi closed this as not planned Won't fix, can't repro, duplicate, stale Mar 30, 2023
@wirednkod
Copy link
Contributor Author

There's not really a way for us to detect this as this is an error from Deno during the caching phase, before any of our code is run.

Feature says - that it would be nice to provide a minimum version, that devs are testing and knows it works.
I am pretty sure that a check can take place - in order to identify if one runs an older version than recommended;

@tjjfvi
Copy link
Contributor

tjjfvi commented Mar 30, 2023

The minimum version supported is the latest v1.x – but it could be worthwhile to document that somewhere.

@wirednkod
Copy link
Contributor Author

wirednkod commented Mar 30, 2023

The minimum version supported is the latest v1.x – but it could be worthwhile to document that somewhere.

No it is not. As this "feature" mentions, deno 1.27.1 would not actually work; Look at Motivation;

I am not sure why there is a rush to close issues/features/bugs before understanding the reason why they were opened. It is a bit frustrating to me and this plus the short-responses provide no value;

@tjjfvi
Copy link
Contributor

tjjfvi commented Mar 30, 2023

Sorry, I meant latest v1.x in an evergreen sense – i.e. 1.32.1 is supported but not 1.27.1. This is fairly common for Deno projects (since Deno is still on major version 1, there haven't been any breaking changes).

I originally closed the issue because the proposed feature – checking the Deno version in the CLI – was infeasible. But since the issue is applicable in the broader context of documenting what versions of Deno we support / considering what versions of Deno we plan to support down the line, it would be good to have an issue. I'll reopen this issue so we'll be sure to follow up.

@tjjfvi
Copy link
Contributor

tjjfvi commented Jul 10, 2023

I've opened #1154 about documenting our Deno version requirement, so I'm going to close this issue.

@tjjfvi tjjfvi closed this as not planned Won't fix, can't repro, duplicate, stale Jul 10, 2023
@vjjft
Copy link

vjjft commented Jul 10, 2023

Would it be possible/reasonable for the deno task capi script to check the Deno version?

@tjjfvi
Copy link
Contributor

tjjfvi commented Jul 10, 2023

In the case mentioned in this issue, it wouldn't be possible, as it was an error during the caching phase, before our code even ran.

We also don't currently have a fixed supported version of Deno – we only support the latest 1.x version of Deno, so there wouldn't be something fixed to check against.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
Status: Done
Development

No branches or pull requests

3 participants