-
Notifications
You must be signed in to change notification settings - Fork 10
Deno version checks #820
Comments
There's not really a way for us to detect this as this is an error from Deno during the caching phase, before any of our code is run. |
Feature says - that it would be nice to provide a minimum version, that devs are testing and knows it works. |
The minimum version supported is the latest v1.x – but it could be worthwhile to document that somewhere. |
No it is not. As this "feature" mentions, deno 1.27.1 would not actually work; Look at Motivation; I am not sure why there is a rush to close issues/features/bugs before understanding the reason why they were opened. It is a bit frustrating to me and this plus the short-responses provide no value; |
Sorry, I meant latest v1.x in an evergreen sense – i.e. 1.32.1 is supported but not 1.27.1. This is fairly common for Deno projects (since Deno is still on major version 1, there haven't been any breaking changes). I originally closed the issue because the proposed feature – checking the Deno version in the CLI – was infeasible. But since the issue is applicable in the broader context of documenting what versions of Deno we support / considering what versions of Deno we plan to support down the line, it would be good to have an issue. I'll reopen this issue so we'll be sure to follow up. |
I've opened #1154 about documenting our Deno version requirement, so I'm going to close this issue. |
Would it be possible/reasonable for the |
In the case mentioned in this issue, it wouldn't be possible, as it was an error during the caching phase, before our code even ran. We also don't currently have a fixed supported version of Deno – we only support the latest 1.x version of Deno, so there wouldn't be something fixed to check against. |
Feature Request
It would nice to have some checks on which Deno version should be used in order for CAPI to work;
Suggestion
Additional message proposal:
or
Motivation
Trying to run examples with CAPI repo - resulted to the error above - once upgraded to latest version, error disappeared
Use Cases
The text was updated successfully, but these errors were encountered: