Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Request] Using links instead of JS (also some options) #3

Open
molster opened this issue Oct 27, 2022 · 0 comments
Open

[Request] Using links instead of JS (also some options) #3

molster opened this issue Oct 27, 2022 · 0 comments

Comments

@molster
Copy link

molster commented Oct 27, 2022

First and foremost this was a great little addition to the nav. However ran into a few issues:

  1. Accessibility: Because these are just spans, screen readers and other form of link detection have no idea the item is a link object to navigate to another page. This can also impact any SEO from these link outs [They are in a nav html block, so some do at least parse it, but not all)

  2. Because these are not links and JS open. There is no way for a user to open these in a new tab, the normal methods of CTRL+Click, Middle mouse button, or right click and open in new tab, do not work due to this not using links. (tho all three options can be supported in a JS click event)

  3. It would be great if we can choose how the links function (EG default opening in a new tab instead of having the users leave the forums for external links)

alxndr added a commit to alxndr/discourse-dropdown-header that referenced this issue May 28, 2024
alxndr added a commit to alxndr/discourse-dropdown-header that referenced this issue May 28, 2024
alxndr added a commit to alxndr/discourse-dropdown-header that referenced this issue May 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant