Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

06_lottery_multiple_winners selectWinners #2

Open
adamskrodzki opened this issue Jul 7, 2018 · 3 comments
Open

06_lottery_multiple_winners selectWinners #2

adamskrodzki opened this issue Jul 7, 2018 · 3 comments

Comments

@adamskrodzki
Copy link
Contributor

Funkcja jest podatna na

Gas Limit Exceeded

należy zastosować pull payment
http://solidity.readthedocs.io/en/v0.4.24/common-patterns.html

@adamskrodzki
Copy link
Contributor Author

adamskrodzki commented Jul 7, 2018

Ponadto:

function selectWinners() public isOwner returns(uint) {
    uint chosen = randomNumber(10);

tu ma być chyba

    uint chosen = randomNumber(100)+1;

@pbrudny
Copy link
Owner

pbrudny commented Jul 7, 2018

@adamskrodzki Zgadza się.

@pbrudny
Copy link
Owner

pbrudny commented Jul 8, 2018

@adamskrodzki Poprawiłem rażące błędy i uprościłem trochę wymagania (wypłata całej kwoty i jednorazowa loteria).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants