Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix conda-specific assumptions #290

Open
ZLLentz opened this issue Sep 22, 2021 · 0 comments
Open

Fix conda-specific assumptions #290

ZLLentz opened this issue Sep 22, 2021 · 0 comments

Comments

@ZLLentz
Copy link
Member

ZLLentz commented Sep 22, 2021

Expected Behavior

The tests should pass regardless of if we install the library via conda, pip, or manually via setup.py or otherwise

Current Behavior

There are some explicit checks for conda-related environment variables here:

base = str(Path(os.environ['CONDA_EXE']).parent.parent)

and potentially similar shenanigans elsewhere.

Context

PIP build fails

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant