Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Race condition in script run test #368

Open
ZLLentz opened this issue Apr 12, 2023 · 0 comments
Open

Race condition in script run test #368

ZLLentz opened this issue Apr 12, 2023 · 0 comments

Comments

@ZLLentz
Copy link
Member

ZLLentz commented Apr 12, 2023

from pcds-5.7.0 integration tests:

____________________________ test_tstpython_scripts ____________________________

    @skip_if_win32_generic
    def test_tstpython_scripts():
        logger.debug('test_tstpython_scripts')
    
>       good_text = check_output([tstpython, 'script.py'])

hutch_python/tests/test_tstpython.py:20: 
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 
../../../../../miniconda3/envs/pcds-5.7.0/lib/python3.9/subprocess.py:424: in check_output
    return run(*popenargs, stdout=PIPE, timeout=timeout, check=True,
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 

input = None, capture_output = False, timeout = None, check = True
popenargs = ([PosixPath('/cds/home/z/zlentz/github/pcds-envs/scripts/tests/hutch-python/hutch_python/tests/tstpython'), 'script.py'],)
kwargs = {'stdout': -1}
process = <Popen: returncode: 139 args: [PosixPath('/cds/home/z/zlentz/github/pcds-env...>
stdout = b' _       _   _____       _   _                 \n| |     | | |  __ \\     | | | |                \n| |_ ___| |_| |__...rapped\n    raise RuntimeError(\'Expected CA context is unset\')\nRuntimeError: Expected CA context is unset\nERROR   '
stderr = None, retcode = 139

    def run(*popenargs,
            input=None, capture_output=False, timeout=None, check=False, **kwargs):
        """Run command with arguments and return a CompletedProcess instance.
    
        The returned instance will have attributes args, returncode, stdout and
        stderr. By default, stdout and stderr are not captured, and those attributes
        will be None. Pass stdout=PIPE and/or stderr=PIPE in order to capture them.
    
        If check is True and the exit code was non-zero, it raises a
        CalledProcessError. The CalledProcessError object will have the return code
        in the returncode attribute, and output & stderr attributes if those streams
        were captured.
    
        If timeout is given, and the process takes too long, a TimeoutExpired
        exception will be raised.
    
        There is an optional argument "input", allowing you to
        pass bytes or a string to the subprocess's stdin.  If you use this argument
        you may not also use the Popen constructor's "stdin" argument, as
        it will be used internally.
    
        By default, all communication is in bytes, and therefore any "input" should
        be bytes, and the stdout and stderr will be bytes. If in text mode, any
        "input" should be a string, and stdout and stderr will be strings decoded
        according to locale encoding, or by "encoding" if set. Text mode is
        triggered by setting any of text, encoding, errors or universal_newlines.
    
        The other arguments are the same as for the Popen constructor.
        """
        if input is not None:
            if kwargs.get('stdin') is not None:
                raise ValueError('stdin and input arguments may not both be used.')
            kwargs['stdin'] = PIPE
    
        if capture_output:
            if kwargs.get('stdout') is not None or kwargs.get('stderr') is not None:
                raise ValueError('stdout and stderr arguments may not be used '
                                 'with capture_output.')
            kwargs['stdout'] = PIPE
            kwargs['stderr'] = PIPE
    
        with Popen(*popenargs, **kwargs) as process:
            try:
                stdout, stderr = process.communicate(input, timeout=timeout)
            except TimeoutExpired as exc:
                process.kill()
                if _mswindows:
                    # Windows accumulates the output in a single blocking
                    # read() call run on child threads, with the timeout
                    # being done in a join() on those threads.  communicate()
                    # _after_ kill() is required to collect that and add it
                    # to the exception.
                    exc.stdout, exc.stderr = process.communicate()
                else:
                    # POSIX _communicate already populated the output so
                    # far into the TimeoutExpired exception.
                    process.wait()
                raise
            except:  # Including KeyboardInterrupt, communicate handled that.
                process.kill()
                # We don't call process.wait() as .__exit__ does that for us.
                raise
            retcode = process.poll()
            if check and retcode:
>               raise CalledProcessError(retcode, process.args,
                                         output=stdout, stderr=stderr)
E               subprocess.CalledProcessError: Command '[PosixPath('/cds/home/z/zlentz/github/pcds-envs/scripts/tests/hutch-python/hutch_python/tests/tstpython'), 'script.py']' returned non-zero exit status 139.

../../../../../miniconda3/envs/pcds-5.7.0/lib/python3.9/subprocess.py:528: CalledProcessError
----------------------------- Captured stderr call -----------------------------
/cds/home/z/zlentz/github/pcds-envs/scripts/tests/hutch-python/hutch_python/tests/tstpython: line 6: 26576 Segmentation fault      (core dumped) hutch-python --cfg conf.yaml $@
------------------------------ Captured log call -------------------------------
DEBUG    hutch_python.tests.test_tstpython:test_tstpython.py:18 test_tstpython_scripts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant