Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Style sheets usage from the lucid grid vs as-launched from related displays #100

Open
klauer opened this issue Mar 21, 2022 · 4 comments
Open
Assignees

Comments

@klauer
Copy link
Contributor

klauer commented Mar 21, 2022

Loading up the BTPS screen from las (${EPICS_SETUP}/lucid-launcher.sh LAS), and popping it out results in this awful looking display:

image

Whereas the configuration editor loads up without the typhos stylesheet via the PyDM related display widget, which looks roughly as it was designed:

image

Not sure of a really appropriate fix here, but some reactionary thoughts follow:

  • The typhos stylesheet remains ugly
  • Maybe an opt-out mechanism for the typhos stylesheet somehow?
@ZLLentz
Copy link
Member

ZLLentz commented Mar 30, 2022

I saw some other wonky stylesheet behaviors today that I can't explain. The chemrixs vacuum screen does not open (or doesn't use?) the stylesheets correctly when opened as a related display from lucid specifically, but it works from from lucid as a shell script and it works fine outside of lucid as a related display. I don't know if this is related at all but the title seemed to match... I have so far be unable to understand what exactly is wrong here.

@ZLLentz
Copy link
Member

ZLLentz commented Nov 17, 2022

I don't think lucid ever calls pydm's stylesheet mechanisms
https://github.com/slaclab/pydm/search?q=apply_stylesheet
https://github.com/pcdshub/lucid/search?q=pydm

@ZLLentz ZLLentz self-assigned this Nov 17, 2022
@ZLLentz
Copy link
Member

ZLLentz commented Nov 17, 2022

PyDMRelatedDisplayButton is opening a window with no parent that can only inherit a stylesheet from the QApplication, which gets set up with a stylesheet courtesy of typhos.use_stylesheet
https://github.com/slaclab/pydm/blob/dc0346004fa15d13ddfe198f21f62bbdf585b715/pydm/widgets/related_display_button.py#L464

typhos.use_stylesheet(dark=dark)

https://github.com/pcdshub/typhos/blob/76486e30b16daf81df3e475ada978affa1ef68a1/typhos/utils.py#L232
https://github.com/pcdshub/typhos/blob/76486e30b16daf81df3e475ada978affa1ef68a1/typhos/ui/style.qss

@ZLLentz
Copy link
Member

ZLLentz commented Nov 17, 2022

First stab at this here, but I ran into some conceptual roadblocks: slaclab/pydm#950

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants