Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hint view is clipped #11

Open
aerze opened this issue Dec 13, 2017 · 2 comments
Open

Hint view is clipped #11

aerze opened this issue Dec 13, 2017 · 2 comments
Labels

Comments

@aerze
Copy link

aerze commented Dec 13, 2017

First, awesome extension 🥇

I tested it by immediately browsing this same repo and the hint gets clipped by the code view.

You can reproduce by going to octohint/scripts/get-node-libs.js and hovering over fs.readFileSync

screen shot 2017-12-13 at 13 08 29

@pd4d10 pd4d10 added the bug label Dec 15, 2017
@ideadapt
Copy link

Fixable via position: absolute; on $background div. At least in chrome this works.

@pd4d10
Copy link
Owner

pd4d10 commented Dec 28, 2017

@ideadapt Thanks. Actually it is absolute at first. We change it to relative to fix #10.

I think it is better to calculate the height, then decide to show it up or down, to make sure it is not clipped.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants