-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
winPEAS.ps1 powershell script does not work on non-english systems #434
Comments
Any news about this @RandolphConley ? |
I am looking into this. Hopefully will have a solution soon. |
This was a fun problem. I have updated the code and will push to origin. It should be resolved now. |
@RandolphConley the "USER INFO" part is still unchanged, isn't it? |
@shaaati - thank you for your patience. This has been fixed as well and has been submitted for approval to origin. |
No worries, I appreciate a lot that you put work into this in your spare time! Just wanted to make sure that no aspect is missed. I hope I didn't come over too pushy/greedy. Thank you for your support and for the prompt fix! |
This happens to me quite often, as I am mostly pentesting German companies. It should be a general issue with every non-english system, though.
In certain lines, winPEAS references command output by its column names. At least the following two lines are affected:
PEASS-ng/winPEAS/winPEASps1/winPEAS.ps1
Line 70 in 7979c47
PEASS-ng/winPEAS/winPEASps1/winPEAS.ps1
Line 1228 in 7979c47
On non-english systems, the property "group name" does not exist and therefore the command fails. I am no Powershell/Windows CLI expert and therefore do not know how this should be implemented in a language-agnostic way. Can columns be adressed by their index?
Currently, I
sed "s/group name/Gruppenname/"
, but this is obviously not the way to go.@RandolphConley since you are the maintainer of the powershell script, it probably makes sense to tag you.
Edit: This also affects the "USER INFO" block where local groups are accessed by their English names:
PEASS-ng/winPEAS/winPEASps1/winPEAS.ps1
Lines 1236 to 1249 in 7979c47
The text was updated successfully, but these errors were encountered: