Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add link to subscan explore on the transaction status pop-up #471

Closed
prayagd opened this issue May 28, 2024 · 7 comments · Fixed by #557
Closed

Add link to subscan explore on the transaction status pop-up #471

prayagd opened this issue May 28, 2024 · 7 comments · Fixed by #557
Assignees

Comments

@prayagd
Copy link
Collaborator

prayagd commented May 28, 2024

Context

Currently if the swap txn executed by the user is successful or failed on-chain only the status of that is displayed on the pop-up. There is no link to the explorer.

Requirment

  • Once the user initiates the swap transaction
  • If the txn is successful on-chain
    • Add a link to the subscan transaction on the Transaction successful pop-up with text "View on Explorer" above the close button
  • If the txn is fails on-chain
    • Add a link to the subscan transaction on the Transaction failed pop-up with text "View on Explorer" above the close button

Note

  • This is only for Pendulum
  • Reference of the pop-up
    image
@prayagd
Copy link
Collaborator Author

prayagd commented May 28, 2024

Hey team! Please add your planning poker estimate with Zenhub @ebma @Sharqiewicz

@Sharqiewicz Sharqiewicz self-assigned this Sep 3, 2024
@Sharqiewicz Sharqiewicz removed their assignment Sep 3, 2024
@prayagd
Copy link
Collaborator Author

prayagd commented Sep 3, 2024

@TorstenStueber: ensure that the api-solang library returns that info

@TorstenStueber
Copy link
Member

Why is this ticket considered blocked? Because it only applies to Pendulum?

@prayagd
Copy link
Collaborator Author

prayagd commented Sep 4, 2024

Yes, it is possible to ship this even though the Pendulum deployment is not live?

@Sharqiewicz
Copy link
Collaborator

@prayagd I think we can make the code so that it works when the Pendulum implementation is live. I'll remove the Blocked label

@Sharqiewicz Sharqiewicz self-assigned this Sep 5, 2024
@prayagd
Copy link
Collaborator Author

prayagd commented Sep 11, 2024

@ebma can we pick this one?

@ebma ebma self-assigned this Sep 11, 2024
@ebma
Copy link
Member

ebma commented Sep 11, 2024

Sure @prayagd, I'll give it a shot

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants