Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate ARS/Anclap into the offramp flow #172

Open
prayagd opened this issue Sep 24, 2024 · 11 comments
Open

Integrate ARS/Anclap into the offramp flow #172

prayagd opened this issue Sep 24, 2024 · 11 comments
Assignees

Comments

@prayagd
Copy link
Collaborator

prayagd commented Sep 24, 2024

Context

This ticket enables ARS offramps.

TODO

  • Add ARS to the currency dropdown on the withdraw page, icon linked below
  • Extend the SEP-24 fee logic to allow for a relative and fixed fee
    • define the proper fee parameters for ARS offramps: 2% relative fee and 10 ARS fixed fee
  • When user selects ARS as offramping currency and agrees to the quote
  • Add ARS as an output currency and define the output token configuration accordingly
  • Implement the Anclap anchor UI when the user selects ARS to offramp
  • Introduce a SEP-10 master account secret configuration for the signer service
    • Use the corresponding account as the source account for SEP-10 when Anclap is used as the anchor
    • In that case securely add the SEP-10 signature on the backend

Notes

Notes

ARS icon - https://static.anclap.com/coin/ars.png

@prayagd prayagd added the draft label Sep 24, 2024
@gianfra-t
Copy link
Contributor

@pendulum-chain/product can this be worked already?

@vadaynujra
Copy link

Not till we have the asset live on Spacewalk and Forex AMM (with some col and liq respectively), which is why it is still in draft @gianfra-t

@prayagd
Copy link
Collaborator Author

prayagd commented Oct 4, 2024

@pendulum-chain/product can this be worked already?

I will get this ready and estimated till then

@prayagd prayagd removed the draft label Oct 4, 2024
@prayagd
Copy link
Collaborator Author

prayagd commented Oct 4, 2024

@pendulum-chain/devs please check if the description is enough this to be estimated?

@prayagd
Copy link
Collaborator Author

prayagd commented Oct 4, 2024

@gianfra-t gianfra-t self-assigned this Oct 4, 2024
@gianfra-t
Copy link
Contributor

I'll assign myself to this since I can test the flow with my bank.

@TorstenStueber
Copy link
Member

Just want to point out that ARS is not available yet on the AMM. But this should not be a blocker for this ticket here.

@gianfra-t
Copy link
Contributor

Yes @TorstenStueber thanks. Since the changes are very small, I'll wait for ARS to be "ready" to work on this and test an off-ramp.

@TorstenStueber
Copy link
Member

@gianfra-t FYI, this has been unblocked now as ARS is now available on Nabla: https://github.com/pendulum-chain/tasks/issues/401#issuecomment-2412361777

@prayagd
Copy link
Collaborator Author

prayagd commented Oct 22, 2024

@gianfra-t if and when you are unblocked for testing. please record the entire flow and share the recording

@TorstenStueber
Copy link
Member

I incorporated the description of #173 into this issue and added a description of the SEP-10 master account so that this ticket here corresponds to the.

I will close #173.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants